Hacker Newsnew | past | comments | ask | show | jobs | submit | more lambda's commentslogin

Yeah, this is the problem with people centralizing on GitHub.

But anyhow, just set up a mirror at BitBucket or Gitorious, and have them push to one of those for pull requests.


Small question, git noob here. The comments that we see on github (outside of the commit messages), are these comments stored on github, or is it something git related.

Logically I would think the comments are just an extra layer added by github, but theoritically git could have comments also decentralized and stored, this is why I'm asking.


Yeah, the comments are an extra layer added by GitHub, and not stored in the repo itself.

You're right that it would be possible to also decentralize the comments, but that's not how GitHub does it, they just store those on their own, and there's no part of Git that is explicitly built for storing code review comments, you would need to add something on top using the "note" system or something similar.



Do see the "limitations" section:

github-backup is repository-focused. It does not try to back up other information from GitHub. In particular, social network stuff, like users who are following you, is not backed up.

github-backup does not log into GitHub, so it cannot backup private repositories.

Notes added to commits and lines of code don't get backed up yet. There is only recently API support for this.

The labels that can be added to issues and milestones are not backed up. Neither are the hooks. They could be, but don't seem important enough for the extra work involved. Yell if you need them.


So, it backs up most of everything, just a couple of the deeply commented stuff doesn't work. All issues for example get backed up. It feels more like it back "most" things up and leaves out only a couple of things.


Comments and tickets on github are github only.


That text is already on bitbucket: https://bitbucket.org/w2trsdef3/trapapa Streisand effect is in place.


I'm just somewhat puzzled that twox is a default. It seems like a prime candidate not to be just due to these sorts of inevitable problems. Lots of people new to discussion boards tend not to understand there may be different rules, sets of expected behavior, or the like on different sub-boards, so making something a default is likely to attract lots of people who are new and don't understand the rules.

Once you couple that with the general population skewing fairly male, young, not necessarily good with social norms, and a strong pseudo-libertarian streak, it just doesn't seem like a good combination with a sub that's supposed to be by and for women.

I'm curious why the mods decided to let it become a default.


"I'm curious why the mods decided to let it become a default."

Seeing as reddit is just usenet of the 80s and early 90s on a web page in 2014, both in application, discussion topics, and more or less in culture, one lesson from usenet readers of the dark ages was there are or should be no default groups.

I don't remember any default usenet groups in nn, tin, gnus... The same social pressures that lead to no defaults then, most likely apply now, even if the tech is slightly different.

"a sub that's supposed to be by and for women."

I lurked there and read a lot. Interesting to see their opinions vs mine. Eventually it got boring. Encouraging half or more of the new user population to lurk before posting was another usenet thing. So looking at it that way, it might be a good idea to force noobs to read, at least till they learn how to remove a default subreddit.

So I've presented two arguments, one for and one against. I think the argument against is slightly stronger although I could appreciate a good alternative interpretation.


> I don't remember any default usenet groups in nn, tin, gnus

The news protocol specifically included a recommendation mechanism for "default subscribed groups", so that a news administrator could point new users to some important groups.

In Gnus that behaviour is triggered by the variable gnus-default-subscribed-newsgroups.

I'm certain that nn, tin and whatnot supported it, as well.


Mods don't decide to make a subreddit a default, admins do.


That's not true, mods can opt out of becoming a default and at least in some cases the admins talk to the mods first anyway.

edit: http://i.imgur.com/IbiMa8g.png


This is true. I am a moderator for /r/mildlyinteresting and two weeks before we became a default, we were asked if we wanted to opt-out. It was hotly-debated between the moderators for about a week and any one of us could have answered the admin, but we put it to a vote and ended up becoming a default.


That image related to posts from that subreddit being seen in /r/all. Automoderater puts /r/all flair on such posts in certain subreddits.


The highlighted part is only 15 words. Why stop reading after 7?


That they can opt out does not mean they can opt in.


The mods were absolutely involved in the decision to make the subreddit a default. Unfortunately, moderators are not elected and they cannot be usurped. They have no obligations to their subscribers, and indeed in this case they made the decision behind closed doors.


> Unfortunately, moderators are not elected and they cannot be usurped. They have no obligations to their subscribers,

This is one of the big weaknesses of Reddit right now. As far as I can tell, who gets to moderate powerful subreddits comes down the the accident of history of who happened to think of it first. Several of the subreddits I frequent have had moderators slam down rules that most of the community disagree with (just for example /r/Android has a rule that you cannot post "questions", it is only for "news about Android" ...). This leads to a high variability in the quality of the moderation and curation of various subreddits. I'm not sure what the best alternative idea woudl be, but something better than "whoever thought of it first" should be possible.


The other end of the spectrum is the Stack Overflow method, which ends up with the most uptight and pedantic users ending up with all the control, who use their power to rain havoc upon those who might otherwise have been much better moderators.

With Reddit, you at least have a chance of having a semi-decent group of moderators who can care for and foster their community without it turning into an anal retentive hell.


I was under the impression that the admins consulted with the mods before doing so, but I could be wrong; how the front page has worked has changed many times over the years, and I haven't been keeping very close track.


They send you a message, but at that point it's already been decided what they have chosen to be the defaults.


You can always opt out though. There's literally a check box you can change if you don't want it anymore. You don't uncheck that box without a lot of communication and deliberation generally, but it's there.


I'm sure that the admins would remove any sub that asked from the default list.


Mods can opt out of being in /r/all (and from being a default with the same checkbox.)


No, it is not "their data."

When I rent a safe deposit box from a bank, and store my valuables in it, my valuables do not become the property of the bank.

Likewise, just because I store some data on someone else's computer system does not make that data theirs.

Now, we may not yet have a good enough legal framework for protecting our data; in Europe, laws about this are better, while in the US you are expected to just use contract law for this purpose, and of course with online services you have no way of negotiating the contract and they always claim the right to do anything they want with the data.

But that does not make it "their data"; it just means that our laws need to be updated to better protect our data and not allow companies to simply claim they can do anything they want in non-negotiable user agreements.


There is a difference between is and should be. Your valuables stored in a safe deposit box are still yours because its illegal for banks to look inside a safe deposit box outside an emergency. But no such laws exist for cloud data, and more importantly, every interaction you have with a cloud provider happens against the background understanding that the cloud provider has zero obligation to you regarding any data you put on their systems.

You can argue that things should be different. What I am talking about is how things are.


The law is miles away from actually treating it as your property in someone else's hands. Europe has so far only started addressing the issue of "private information", which is data about you which you might or might not own.

The law around physical property in someone else's hands is on the other hand well established, and is referred by English speaking lawyers as "bailment". If you entrust people with your stuff and they misbehave, they are then liable for their negligence about it. So the legal theory should be simple, but "on the internet" is masquerading the issue. If I send some clothes to the dry cleaners to get cleaned, it is still my clothes. If I send some emails to be cleaned by a spam filter service, it suddenly is no longer my emails anymore. There is no reason why we need any new law to correct this, but there is political work to make it enforceable.

: https://en.wikipedia.org/wiki/Bailment


Depends what you are talking about when you say "their data". At a base level Facebook can read it, delete it, copy it, move it, etc. and you cannot, so it only makes sense to say they own it and you do not.

It's only when you add a shared construct like some system of ethics or law that your definition of data ownership make sense.

It's the difference between ownership defined by abilities and ownership defined by rights. It's a failure of the English language.

Computer security, especially, encourages you to think in base, practical (there must be a better word for this) terms. Since you can't guarantee other actors will respect your rights, you fall back to "If I don't want X done then I must make it physically impossible to do X rather than just wrong to do X".


> When I rent a safe deposit box from a bank, and store my valuables in it, my valuables do not become the property of the bank.

Depends on the T&C [1]. Two things here, (1) you agreed to the FB terms and (2) took no steps to ensure your privacy despite these ever changing terms. More applicable digital lockbox hypo: when you put a gig of encrypted data on S3, AWS doesn't scan it and try to sell it to advertisers because you didn't agree to that. Further, they'd have to crack your encryption (i.e. PGP) as well if they wanted to violate those terms.

With AWS you get what you paid for. With FB, advertisers get what they paid for you.

[1] https://www.facebook.com/legal/terms


Yes it's their data. The moment you click "I AGREE", it becomes their data.


There's some serious equivocation going on here around the ownership of the data. It's your data; you own copyright on it. Per the TOS, you grant them an "irrevocable, royalty-free license" to do things with the data.

(The set of things they can do with the data is subject to change, with notification, but if those changes are "adverse" to you, you have the right to revoke that consent. What happens to your data after that consent is revoked is something that probably needs to be explored legally, but it's pretty widely known that Facebook never actually deletes anything. And the TOS do say "irrevocable", after all...)

All that said, it's not their data. (Effectively) unlimited access, yes; ownership, no.


The one major one I found was the DHCP vulnerability; if you use ifupdown and configure and interface via DHCP, that uses dhclient, which invokes dhclient-script with attacker controlled variables. dhclient-script is explicitly written in bash, so is vulnerable.

I've tried doing explicit grepping for bash throughout various source code, but it's a lot of work to then trace back if that particular script is ever executed by some chain of commands that ultimately originated from something networked which sets environment variables to attacker controlled values.


You missed one of the big ones, DHCP. dhclient calls dhclient-script with attacker controlled environment variables, and on several Linux distros I checked, dhclient-script explicitly uses Bash, so even Debian and Ubuntu, which use dash as sh, are vulnerable.


Someone else already pointed this out in my comments section. I'm working on an update.


Let's see. There was Apple's iTools, .mac, MobileMe, and now iCloud service (sort of one big evolving service, with some bits chopped off or replaced at various points in time), which has gone from free to paid to freemium.

There's Google Apps for your Domain, which killed off its free service in favor of the $5/user per month service.

Ning shut down their free service and switched to a paid only model.

DynDNS also shut down their free service, only offering paid.

How many more examples do you need?


I can't speak to the rest, but I still have free Google Apps for my personal domain. They're no longer offering it for new customers, but those who signed up when it was free still have it.


I recall those being free. I don't remember any of them being marketed as "Free forever". If you have even one example that you can document as being falsely advertised as "Free forever"...


If you're vulnerable to this, then you're vulnerable to someone setting PATH and changing all executables that you refer to.

That's not the "shock" part of "shellshock"; that's a long known issue. Applications which pass arbitrary variables from the network through environment variables already add a unique prefix to the variables, to prevent this kind of problem. That unique prefix also prevents them from accidentally conflicting with the name of an actual executable for this case.

Now, there are still going to be bugs with suid executables not sanitizing their environment, but those apply in many other ways, such as via PATH and LD_PRELOAD.

The "shock" part of shellshock was that it was possible to execute arbitrary code, upon just loading a variable in Bash, regardless of what its name was, depending only on the contents, which in many cases can be attacker controlled.


Exactly. If you are letting an attacker define not just the values of environment variables, but also the names, then you've already lost.

Forget bash. LD_PRELOAD by design lets you load arbitrary code into any child process. Many other environment variables affect libc and other common libraries in arbitrary ways. setuid programs must clear their environment at startup to be safe. Programs like sudo can restore that environment once the user is authorized for root access.


One thing to recall is that much of the complexity in systemd comes from replacing a whole bunch of dodgy, special purpose code written in shell scripts (init scripts) and in the daemons it manages (daemonization code, various kinds of racy startup dependencies, etc).

Just saying "systemd is complex" is fairly sloppy thinking; the question is, is it more or less complex than re-implementing that functionality poorly and incompatibly several dozen other times in various other daemons and startup scripts?


There's significantly less complex ways to do this sort of thing, though. One that I've been looking at implementing into a distro lately is nosh[0] (and execline[1]). Every bit of code is implemented as a separate, independent utility that can be chained together through the nosh/execlineb "shell", which does no parsing and only a tiny bit of lexing.

This way, it's easy to pick and choose what features and complexity each script needs, and the features that you don't use can't affect you. Nothing is running on your system that you don't know about, and there's no complex "magic" anywhere unless you explicitly ran a command which does magic things.

[0] http://homepage.ntlworld.com/jonathan.deboynepollard/Softwar... [1] http://skarnet.org/software/execline/


Execline is a little mindbending at first, but a really nice way to write scripts for launching other programs.


The question is, does it call bash in its dhclient-script? I took a look through the FreeBSD source tree, and their version of dhclient-script uses /bin/sh. As long as /bin/sh is not bash (and that script doesn't in turn call any other bash scripts) it should be OK.

The best way to find out if you're vulnerable is by testing. It takes just a few minutes to set up dnsmasq to serve up an exploit. Here were my settings:

  interface=eth2
  dhcp-range=10.0.1.100,10.0.10.200,12h
  dhcp-option-force=114,() { :; }; echo "hi"
Of course, replace that 'echo "hi"' with the exploit of your choice. In my case, the output from dhclient would be printed on screen when restarting networking, so 'echo "hi"' was sufficient to verify that it was being executed.

If any bash scripts are called, with the environment variables that are set by dhclient, then that snippet should be run. If bash is not invoked, then that snippet won't ever run.


You can pretty much guarantee that nothing in the core system for FreeBSD calls Bash, because Bash isn't in the core system :)


What were you using to configure networking on the target machine? NetworkManager, ifupdown, something else?

I found that with ifupdown, you see the issue, as it uses dhclient which in turn calls out to dhclient-script, which is written in bash. If you use NetworkManager, it doesn't call dhclient-script; it does however call the scripts in /etc/network/if-.d, and if any of those are written in bash, then you see the issue. None of the scripts in /etc/network/if-.d on my system used bash, they all used /bin/sh, so on a Debian system where that points to dash instead of bash you're OK.


Of course I've used dhclient for this (also with -r option) with ifconfig up/down. Not working. I've also tried to re-simlink sh to bash. Not working. I'd like to check py script by mschwager (https://github.com/mschwager/shellshock_poc), may be it will be OK.


Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: