Don't forget they were using CRTs and today most people use LCDs

I don't think one is necessarily better than the other "in general" but there are a couple of things to keep in mind:

- White background might be better on more illuminated environments. Too much contrast is bad

- Syntax highlighting is easier to resolve on a dark background