I think LSP is great. I've used it in one my side projects to quickly add support for VS Code. We took a more direct approach. Instead of having a separate LSP server our main program runs on LSP server mode. This made a lot of things like distribution and interaction with the core functionality simpler.

LSP also solves a big pain by making it easy to build tooling when teams choose to implement an external DSL's.