Metaphors are of course imperfect by their very nature, but more importantly, the phrase “a roller coaster of emotions” isn’t even really a metaphor. It’s a figure of speech that means one is going through a wide range of feelings and/or emotions in a (relatively) short amount of time, possibly in rapid succession or even simultaneously. I think it was used appropriately.