Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

I see your point, but I'm not suggesting a general "email first before pull request" policy, which I agree would be a big mistake.

I feel like this was actually a very unusual situation.



Ok. If it's not a policy, then I don't think there's any way you can expect a potential contributor to know that a particular pull request must be preceded by discussion. In which case, I think the burden falls on the person reviewing the requests. In this case, Noordhuis. The submitter did their bit by making a positive change and offering the patch.




Consider applying for YC's Summer 2026 batch! Applications are open till May 4

Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: