Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

Great article! Mislav definitely knows his git.

What he didn't point out though is that he was actually the one that contributed that code in the first place.

https://github.com/madrobby/zepto/pull/586

https://github.com/madrobby/zepto/commit/3d92f20966aa02dee82...

As others have commented, long explanations like this have no place in commit messages. Comments should always be used to explain what you're doing and why you're doing it. Commit messages should simply summarize what you did.

A better commit message would have simply been:

fix animate() for elements just added to DOM

See included comments for explanation.



Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: