In terms of how it is marketed cryonics may be scammy by drastically overselling the chances of success, but I'd expect many people who sign up for it see it for what it is: an extremely long bet with money they don't have any further use for anyway.

Unless you have other things you care deeply about spending your money on, there's pretty much only upside.